Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security][Profiler] Display the original expression in 'Access decision log'#26273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@lyrixx
Copy link
Member

@lyrixxlyrixx commentedFeb 22, 2018•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#24127
LicenseMIT
Doc PR

before:

screenshot at 2018-02-22 18-22-28

after:

after

@stof
Copy link
Member

I suggestalso adding my patch from#24127 (comment) (the second one), to useprofiler_dump(first) whenfirst represents a non-string value, instead of displaying the string-casting of the Data object (the class name with the number of property in it is totally useless).

We might even consider this as a bugfix.

{{decision.attributes|first }}
{%setfirst=decision.attributes|first %}
{%iffirst.expressionisdefined %}
Expression: <code><pre>{{first.expression }}</pre></code>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

should be<pre><code></code></pre> as<code> is an inline element while<pre> is a block element.

@lyrixx
Copy link
MemberAuthor

@stof I addressed your comments.

@fabpot
Copy link
Member

Looks like a bug fix to me, no?

@lyrixxlyrixxforce-pushed thesecurity-profiler-expression branch fromafcd558 to8f16c2eCompareFebruary 28, 2018 08:33
@lyrixxlyrixx changed the base branch frommaster to3.4February 28, 2018 08:33
@lyrixx
Copy link
MemberAuthor

I have rebased my branch onto 3.4, and changed the base branch for this PR in order to merge it as a bug fix.

chalasr
chalasr approved these changesMar 2, 2018•
edited
Loading
@nicolas-grekas
Copy link
Member

Thank you@lyrixx.

@nicolas-grekasnicolas-grekas merged commit8f16c2e intosymfony:3.4Mar 19, 2018
nicolas-grekas added a commit that referenced this pull requestMar 19, 2018
…ccess decision log' (lyrixx)This PR was merged into the 3.4 branch.Discussion----------[Security][Profiler] Display the original expression in 'Access decision log'| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#24127| License       | MIT| Doc PR        |---before:![screenshot at 2018-02-22 18-22-28](https://user-images.githubusercontent.com/408368/36553752-798001ba-17fd-11e8-9539-254a25a01e60.png)after:![after](https://user-images.githubusercontent.com/408368/36553856-b7449fe2-17fd-11e8-94cb-ddaf4f033511.png)Commits-------8f16c2e [Security][Profiler] Display the original expression in 'Access decision log'
@lyrixxlyrixx deleted the security-profiler-expression branchMarch 19, 2018 17:28
This was referencedApr 3, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof requested changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

+1 more reviewer

@SimperfitSimperfitSimperfit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

7 participants

@lyrixx@stof@fabpot@nicolas-grekas@Simperfit@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp