Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
fix custom radios/inputs for checkbox/radio type#26254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedFeb 21, 2018
mpiot commentedFeb 21, 2018
It's ok for me :) |
Nyholm commentedFeb 21, 2018
Excellent Marek. Thank you. Could you make a small update PR to the from here:https://github.com/Nyholm/symfony-bootstrap-form/blob/master/src/Form/SuperFormType.php I want to see the difference of the output. |
mssimi commentedFeb 21, 2018
@Nyholm that form is shared with several css frameworks, this feature is specific for bootstrap 4, should I rly submit PR? |
Nyholm commentedFeb 21, 2018
Yes please. Im not really sure what a custom radio is to be honest. |
mpiot commentedFeb 21, 2018 via email
It's just a different CSS applied on a checkbox or a radio in the bootstrap4 framework. It does a nice box/radio. |
Nyholm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Awesome. Thanks. 👍
fabpot commentedFeb 21, 2018
Thank you@mssimi. |
This PR was merged into the 3.4 branch.Discussion----------fix custom radios/inputs for checkbox/radio type| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? || Fixed tickets |#25715| License | MIT| Doc PR |Hey, I tried new changes in bootstrap 4 layout. Unfortunatelly custom-radios/checkboxes seems to work only for ChoiceType/EntityType but not for CheckboxType/RadioType. I added changes which I belive fix this issue.Commits-------dd6d1dd fix custom radios/inputs for checkbox/radio type
Hey, I tried new changes in bootstrap 4 layout. Unfortunatelly custom-radios/checkboxes seems to work only for ChoiceType/EntityType but not for CheckboxType/RadioType. I added changes which I belive fix this issue.