Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Fix anchor CSS#26230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedFeb 19, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
does the anchor still work as expected ? ie anchoring to line 100 should create a top screen margin so that L100 is not hidden on the top of the screen, but has some offset before |
ro0NL commentedFeb 19, 2018
you're right. Not sure what the quirk is but it needs to be a block element indeed. Using
For But now there's this random space in both chrome and firefox:
Guess it's comes from a line break in source:
Can have a look at that.. but maybe some real CSS expert knows a better fix. |
ro0NL commentedFeb 19, 2018
Now all good :) |
nicolas-grekas commentedFeb 19, 2018
Thank you@ro0NL. |
This PR was squashed before being merged into the 3.4 branch (closes#26230).Discussion----------[WebProfilerBundle] Fix anchor CSS| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes/no| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!--highly recommended for new features-->Empty source lines overlap in `/_profiler/open?file=x`. AFAIK it's a regression after#23296, but it's the first time i noticed so maybe it's related to a chrome change in between. No real CSS expert.. but this seems to fix it.Before:After:I can confirm both chrome and firefox render as shown in the after screenshot. Firefox worked before as well, chrome not.cc@ogizanagiCommits-------ee45992 [WebProfilerBundle] Fix anchor CSS
Uh oh!
There was an error while loading.Please reload this page.
Empty source lines overlap in
/_profiler/open?file=x. AFAIK it's a regression after#23296, but it's the first time i noticed so maybe it's related to a chrome change in between. No real CSS expert.. but this seems to fix it.Before:
After:
I can confirm both chrome and firefox render as shown in the after screenshot. Firefox worked before as well, chrome not.
cc@ogizanagi