Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Added support for name on the unit node#26149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas approved these changesFeb 14, 2018
fabpot approved these changesFeb 15, 2018
Member
fabpot commentedFeb 15, 2018
Thank you@Nyholm. |
fabpot added a commit that referenced this pull requestFeb 15, 2018
This PR was squashed before being merged into the 4.1-dev branch (closes#26149).Discussion----------Added support for name on the unit node| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#25758| License | MIT| Doc PR | naSee [unit specification](http://docs.oasis-open.org/xliff/xliff-core/v2.0/os/xliff-core-v2.0-os.html#unit) and [name specification](http://docs.oasis-open.org/xliff/xliff-core/v2.0/os/xliff-core-v2.0-os.html#name)Commits-------30a22aa Added support for name on the unit node
MemberAuthor
Nyholm commentedFeb 15, 2018
Thank you for merging |
symfony-splitter pushed a commit to symfony/translation that referenced this pull requestMar 30, 2018
…o long for "name" (Nyholm)This PR was merged into the 4.1-dev branch.Discussion----------[Translation] XLIFF2: Make sure to trim source if it is too long for "name"| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |This PR is a follow-up on@javiereguiluz's comment here:symfony/symfony-docs#9302This feature was introduced insymfony/symfony#26149Commits-------ca41fecfd9 Make sure to trim source if it is too long
fabpot added a commit that referenced this pull requestMar 30, 2018
…o long for "name" (Nyholm)This PR was merged into the 4.1-dev branch.Discussion----------[Translation] XLIFF2: Make sure to trim source if it is too long for "name"| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |This PR is a follow-up on@javiereguiluz's comment here:symfony/symfony-docs#9302This feature was introduced in#26149Commits-------ca41fec Make sure to trim source if it is too long
Merged
axi commentedJan 14, 2020
Any specific reason this hasn't been merge in 3.4 ? |
MemberAuthor
Nyholm commentedJan 14, 2020
Excellent question. Yes, there is a reason. This was a new feature. 3.4 will not include new features, only bug fixes and security fixes. Symfony is using version numbers like x.y.z. X is a major change (can break BC). Y is added features. Z is bug fixes. You can read more about Semver here:https://semver.org/ You can also see Symfonys release process here:https://symfony.com/releases |
axi commentedJan 14, 2020
Thanks for the answer, I was preparing a PR to report it to 3.4 but it won't be accepted if I understand. We should definitly move to 4.4... |
SerhiyMytrovtsiy added a commit to SerhiyMytrovtsiy/translation that referenced this pull requestOct 19, 2022
…o long for "name" (Nyholm)This PR was merged into the 4.1-dev branch.Discussion----------[Translation] XLIFF2: Make sure to trim source if it is too long for "name"| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |This PR is a follow-up on@javiereguiluz's comment here:symfony/symfony-docs#9302This feature was introduced insymfony/symfony#26149Commits-------ca41fecfd9 Make sure to trim source if it is too long
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeunit specification andname specification