Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Workflow] Remove constraints on transition/place name + Updated Dumper#26079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lyrixx merged 1 commit intosymfony:masterfromlyrixx:workflow-relax-name
Feb 9, 2018

Conversation

@lyrixx
Copy link
Member

@lyrixxlyrixx commentedFeb 7, 2018
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

(ping@Plopix : I changed a bit the puml dumper)

@Plopix
Copy link
Contributor

@lyrixx I have just checked and I think your .puml result is not syntactically valid.

state"a" <<initial>>state"b""a"--> "b": "t1"

=> That is not valid, you have aSyntax Error
Instead PlantUML as this concept ofaliases

state"a"asa<<initial>>state"b"asba-->b: "t1"

Let me push the valid test fixtures for you to update the dumper accordingly :)

@Plopix
Copy link
Contributor

Plopix commentedFeb 7, 2018
edited
Loading

Finally, there is a simpler way, just addallow_mixing in the header everywhere. Look at the fixtures inside the "square" folder.
Plus remove the if here:https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Workflow/Dumper/PlantUmlDumper.php#L118

cc@lyrixx thx!

@lyrixx
Copy link
MemberAuthor

Thanks@Plopix for the review.

I have testes in real life with really strange char and my code works.
My test was base on this workflow:

        weird:            type: workflow            supports: stdClass # Just a hack            places:                - "a'"                - 'é!'                - 'b\"(\"'            transitions:                -                    name: '{}'                    from: "a'"                    to: 'é!'

And as it's already a workflow, theallow_mixing was already present.
If I remove the" in the pum dump, then it's broken.

Here is the dump

@startumlallow_mixingtitle weirdskinparam titleBorderRoundCorner 15skinparam titleBorderThickness 2skinparam state {    BackgroundColor<<initial>> #87b741    BackgroundColor<<marked>> #3887C6    BorderColor #3887C6    BorderColor<<marked>> Black    FontColor<<marked>> White}skinparam agent {    BackgroundColor #ffffff    BorderColor #3887C6}state "a'" <<initial>>state "é!"state "b\(\"agent "{}""a'" --> "{}""{}" --> "é!"@enduml**But** You are right about the "state_machine dumper". We should always add `allow_mixing`.I have updated the PR.

@lyrixx
Copy link
MemberAuthor

Not really related question: Do you really use thenofooter option of the dumper? (right now, there are not way to use it without writing / editing some code) I no-one use it, I would like to remove it (less code === less bug)

@Plopix
Copy link
Contributor

Yes indeed theallow_mixing is enough and was present in the workflow dump. I just picked one file randomly in your PR that is how I saw that syntax error and testing a workflow I saw it was working then I figured theallow_mixing.

Ok to removenofooter I agree with the less code less bug. (having the footer was prob too fancy)

We should always addallow_mixing. I have updated the PR.

I don't see the changes but I could have a look when done!
thx!

@lyrixx
Copy link
MemberAuthor

I don't see the changes but I could have a look when done!

Indeed, I forgot to push ;) It's not pushed

@lyrixxlyrixx merged commit55a5a7a intosymfony:masterFeb 9, 2018
lyrixx added a commit that referenced this pull requestFeb 9, 2018
… + Updated Dumper (lyrixx)This PR was merged into the 4.1-dev branch.Discussion----------[Workflow] Remove constraints on transition/place name + Updated Dumper| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |(ping@Plopix : I changed a bit the puml dumper)Commits-------55a5a7a [Workflow] Remove constraints on transition/place name + Updated Dumper
@lyrixxlyrixx deleted the workflow-relax-name branchFebruary 9, 2018 14:47
@fabpotfabpot mentioned this pull requestMay 7, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lyrixx@Plopix@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp