Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Workflow] Remove constraints on transition/place name + Updated Dumper#26079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Plopix commentedFeb 7, 2018
@lyrixx I have just checked and I think your .puml result is not syntactically valid. state"a" <<initial>>state"b""a"--> "b": "t1" => That is not valid, you have a state"a"asa<<initial>>state"b"asba-->b: "t1" Let me push the valid test fixtures for you to update the dumper accordingly :) |
Plopix commentedFeb 7, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Finally, there is a simpler way, just add cc@lyrixx thx! |
lyrixx commentedFeb 8, 2018
Thanks@Plopix for the review. I have testes in real life with really strange char and my code works. And as it's already a workflow, the Here is the dump |
lyrixx commentedFeb 8, 2018
Not really related question: Do you really use the |
Plopix commentedFeb 8, 2018
Yes indeed the Ok to removenofooter I agree with the less code less bug. (having the footer was prob too fancy)
I don't see the changes but I could have a look when done! |
lyrixx commentedFeb 8, 2018
Indeed, I forgot to push ;) It's not pushed |
… + Updated Dumper (lyrixx)This PR was merged into the 4.1-dev branch.Discussion----------[Workflow] Remove constraints on transition/place name + Updated Dumper| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |(ping@Plopix : I changed a bit the puml dumper)Commits-------55a5a7a [Workflow] Remove constraints on transition/place name + Updated Dumper
Uh oh!
There was an error while loading.Please reload this page.
(ping@Plopix : I changed a bit the puml dumper)