I'm +1 on the intend.
The UrlMatcher class also needs an update, and the corresponding tests I suppose.

Definitely 👍

Hey Javier, I like your proposal and in the same direction we might need to make some additional changes:

The phrase... and you haven't configured any URLs. could be incomplete now. What about finishing this statement with... at root path. or something similar?

According to your idea, this part should also be updated:

Related fixtures that require updating (files):

In the other hand, I have a concern now about the name/description of this exception, because it does not fit his new scenario, i.e. it'll be thrown even with routes configuration:

$code .="        if ('/' ===\$pathinfo) {\n";if ('' ===$code) {$code .="            throw new Symfony\Component\Routing\Exception\NoConfigurationException();\n";}else {$code .="            throw new Symfony\Component\Routing\Exception\NoRootConfigurationException();\n";}$code .="        }\n";

NoRootConfiguration extends NoConfiguration

I think it doesn't matter much, let's keep things simple IMHO

Status: needs work

So is there a quick fix?

I found this affects 4.0 too. (I just started following the getting started guide with 4.0.)

But I see that this is about the 3.4 branch and the other 4.0 pull requests and issues are closed... so I am wondering if this fix will apply to 4.x too?

@yceruto I'm sorry but I don't know how to make the changes you mentioned inUrlMatcher.php andPhpMatcherDumperTest.php. Can you please give me more details ... or maybe you can take over this PR? Thanks!

About the changes inUrlMatcher you need to remove this statement:0 === count($this->routes) && fromhere, thus we're removing"there are no routes defined" constraint.

And the fixtures related toPhpMatcherDumperTest.php need to be re-dumped. See the diffhere.

@yceruto thanks for your great help! I made the change and tests are now green. Ready for review!

Thank you@javiereguiluz.

Hey@javiereguiluz, will this be ported to the 4.0 branch?

Yes. Pull requests are periodically merged from lower to upper maintained branches, so this will end up in 4.0 and master too. Here is the list of maintained branches:https://symfony.com/roadmap

Fedora 26, Symfony 4.0., just installed (bycomposer create-project symfony/website-skeleton my-project, i update byhttps://github.com/symfony/demo/blob/master/composer.json too).
I get a "No route found for "GET /" error.".
Do you have a fix? Is there a composer command to install it? Thks

@mario6097 It's already fixed, butit has not been released yet.

I use jms/i18n-routing-bundle and update symfony to 3.4.7 and i have problem with this feature.
My config usestrategy: prefix and this situation when referring to / must be a redirect to locale url. But showing homepage without redirect /{locale}
This problem is inPhpMatcherDumper.php
@javiereguiluz

Same like@idildin.
I just updated Symfony from 3.4.6 and now can't get default locale prefix redirect, while it was working like a charm before.

composer.json

"jms/i18n-routing-bundle": "2.0.x-dev",

routing.yml

main_index:    path:     /    defaults: { _controller: AppBundle:Main:index }    methods:  [GET]

config.yml

parameters:    locale: pl    app.languagesSlugs: [ en, pl ]framework:    default_locale:  "%locale%"# JMS I18N Routingjms_i18n_routing:    default_locale: pl    locales: "%app.languagesSlugs%"    strategy: prefix

http://localhost:8000/ - Welcome Page (before redirect tohttp://localhost:8000/pl/)

My question is: should I wait to fix by JMS I18N Routing bundle or by Symfony or is there any workaround to force default language redirect?

Please open dedicated issues instead: you won't get any attention by commenting on closed ones.

Also, this is a BC for everyone involving in progressive migration to Symfony =>https://github.com/PrestaShop/PrestaShop/blob/develop/admin-dev/index.php#L87

I can't imagine what motivated you to change the behavior in an LTS :/

Any workaround?

EDIT: nevermind, it's already fixed with the latest 3.4, thanks :)