Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Process] Check PHP_BINDIR before $PATH in PhpExecutableFinder#26040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedFeb 4, 2018
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25187 |
| License | MIT |
| Doc PR | - |
| } | ||
| } | ||
| if (is_executable($php =PHP_BINDIR.'/php'.('\\' ===DIRECTORY_SEPARATOR ?'.exe' :''))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This logic does not take into account thePATHEXT env var as done inExecutableFinder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
php binaries always are.exe, in php_bindir
fabpot commentedFeb 12, 2018
Thank you@nicolas-grekas. |
…nder (nicolas-grekas)This PR was merged into the 2.7 branch.Discussion----------[Process] Check PHP_BINDIR before $PATH in PhpExecutableFinder| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#25187| License | MIT| Doc PR | -Commits-------3a470c4 [Process] Check PHP_BINDIR before $PATH in PhpExecutableFinder