Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

support sapi_windows_vt100_support for php 7.2+#25972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@jhdxr
Copy link
Contributor

QA
Branch?2.7
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsSee below
LicenseMIT
Doc PRN/A

php 7.2 enabled color support on windows(>=10.0.10586) and introduced a new function calledsapi_windows_vt100_support to get and set the state. this PR add the support for this new function, so users on windows can see the colorful world again with php 7.2+.

@stof
Copy link
Member

@symfony/deciders should we merge this in 2.7, or should we consider it a new feature ?

For reference, the automatic detection of Mintty was backported to 2.3 in the past (see#15915), so merging in 2.7 looks fine.

@nicolas-grekas
Copy link
Member

For 2.7: infrastructure-related changes are bug fixes (similarly to PR fixing issues with newer versions of PHP)

@nicolas-grekasnicolas-grekas added this to the2.7 milestoneJan 30, 2018
@jhdxr
Copy link
ContributorAuthor

travis ci fails due toan issue on the base branch, I'll rebase these changes when it has been fixed if necessary.

@nicolas-grekas
Copy link
Member

Thank you@jhdxr.

@nicolas-grekasnicolas-grekas merged commit5bbb77b intosymfony:2.7Jan 31, 2018
nicolas-grekas added a commit that referenced this pull requestJan 31, 2018
This PR was merged into the 2.7 branch.Discussion----------support sapi_windows_vt100_support for php 7.2+| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | See below| License       | MIT| Doc PR        | N/Aphp 7.2 enabled color support on windows(>=10.0.10586) and introduced a new function called `sapi_windows_vt100_support` to get and set the state. this PR add the support for this new function, so users on windows can see the colorful world again with php 7.2+.Commits-------5bbb77b support sapi_windows_vt100_support for php 7.2+
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@lyrixxlyrixxlyrixx approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

7 participants

@jhdxr@stof@nicolas-grekas@javiereguiluz@lyrixx@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp