NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[dotenv] Support array notation#25942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

sanpii wants to merge1 commit intosymfony:masterfromsanpii:dotenv-array

Closed

[dotenv] Support array notation#25942

sanpii wants to merge1 commit intosymfony:masterfromsanpii:dotenv-array

Conversation

Copy link

Contributor

sanpii commentedJan 27, 2018•
edited
Loading

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR	symfony/symfony-docs#9150

In addition ofFOO[bar]=BAR notation, supported by bash, this PR adds support for empty keys. I don’t know if it’s a good idea.

carsonbot added Status: Needs Review Feature labels

Jan 27, 2018

[dotenv] Support array notation

5ada4f8

xabbuh added the Dotenv label

Jan 27, 2018

Copy link

Member

nicolas-grekas commentedJan 29, 2018

The dotenv file is meant as a fallback when real env vars cannot be used.
Because it's a fallback, it should not allow more features than real env vars allow.
Here, defining a real bash env var as an array is not compatible with e.g. populating the$_SERVER array.
For this reason, this PR is out of scope for the component.

Instead, you should maybe use env processors, seehttps://symfony.com/blog/new-in-symfony-3-4-advanced-environment-variables (3.4 & up) and#25627 (4.1 & up)