Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] keep the context when validating forms#25940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedJan 26, 2018
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25542 |
| License | MIT |
| Doc PR |
xabbuh commentedJan 26, 2018
The context is modified by the nested validator calls for the form children. I am actually not sure if this solution is the best or if we should rather clone the current context before validating the nested data. If someone is able to write a test case for this, that will be really appreciated. I failed miserably. |
xabbuh commentedJan 26, 2018
Status: Needs Review |
nicolas-grekas commentedFeb 3, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(I missed the test change :) )
fabpot commentedFeb 7, 2018
Thank you@xabbuh. |
This PR was merged into the 2.7 branch.Discussion----------[Form] keep the context when validating forms| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#25542| License | MIT| Doc PR |Commits-------317da3b keep the context when validating forms