Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

WIP #25825: Add a failing test to demonstrate bug introduced in #24987.#25852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@greg-1-anderson
Copy link
Contributor

@greg-1-andersongreg-1-anderson commentedJan 20, 2018
edited
Loading

QA
Branch?master
Bug fix?yes (failing tests only for now)
New feature?no
BC breaks?demonstrates BC breaks already committed
Deprecations?tbd
Tests pass?no (this is the purpose of this PR for now)
Fixed tickets#25825,#24987 (aiming to fix this - not yet fixed)
LicenseMIT
Doc PRn/a

This PR adds some failing tests to demonstrate the problem introduced by the above-referenced PR.

The main issue introduced is demonstrated by test[B].hasParameterOption('-s') returns the wrong result because it confuses the characters in the value of the-e flag for additional options.

Proposed resolution:

Back out#24987

Impact:

Symfony Console will once again have the limitation that one cannot usecli.php -fh to set the-f flag AND get help via the-h flag, becausehasParameterOption /getParameterOption only work with short parameters that appear by themselves (e.g.cli.php -f -h). This limitation is necessary becausehasParameterOption() has no access to the input definition.

In the tests below, backing out#24987 would have the following effect:

Remaining work:

The functiongetParameterOption still does not work correctly for short options with values. This bug was pre-existing, prior to#24987, and was not affected by that PR. See the comment on failing test[I].

@nicolas-grekas
Copy link
Member

@greg-1-anderson the fix should be submitted against branch 2.7, isn't it? Would you like to submit one?

@nicolas-grekasnicolas-grekas added this to the2.7 milestoneJan 21, 2018
@greg-1-anderson
Copy link
ContributorAuthor

@nicolas-grekas The bug was committed to many versions of Symfony. If 2.7 is where I should start, I'll be happy to make a PR there to fix this.

@nicolas-grekas
Copy link
Member

Yes, that's how we manage this: we first merge in the lowest branch, then we merge that branch up to master.

@greg-1-anderson
Copy link
ContributorAuthor

Work continues in#25893

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

3 participants

@greg-1-anderson@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp