Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] fix DI extension tests#25847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The failing tests relied on the assets integration being enabled. Sincewe never did enable this explicitly, the assets related definitions areremoved now thatsymfony#25789 was merged whichfixedsymfony#25760.
chalasr approved these changesJan 19, 2018
Member
chalasr commentedJan 19, 2018
Thank you@xabbuh. |
chalasr added a commit that referenced this pull requestJan 19, 2018
This PR was merged into the 3.3 branch.Discussion----------[FrameworkBundle] fix DI extension tests| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |The failing tests relied on the assets integration being enabled. Sincewe never did enable this explicitly, the assets related definitions areremoved now that#25789 was merged whichfixed#25760.Commits-------1cb8f69 [FrameworkBundle] fix DI extension tests
xabbuh commentedJan 20, 2018
| @@ -1,3 +1,5 @@ | |||
| framework: | |||
| assets: | |||
| enabled:true | |||
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
passingnull instead of the nestedenabled key does not have the desired effect, this seems to be unintentionally broken by the changes made in#25789
xabbuh added a commit to xabbuh/symfony that referenced this pull requestJan 22, 2018
This will revertsymfony#25847. Basically, the changes done insymfony#25847 were notwrong per se. However, those changes were not necessary as the testswere not failing because of the missing "assets" config, but due to anissue introduced in the Config component. Furthermore, removing thispart of the config fixtures gives us the benefit that our beforenormalization logic that enables assets support when the templatingintegration is enabled is properly tested.
fabpot added a commit that referenced this pull requestJan 23, 2018
…(xabbuh)This PR was merged into the 3.3 branch.Discussion----------[FrameworkBundle] revert useless tests fixtures changes| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? |no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |This will revert#25847. Basically, the changes done in#25847 were notwrong per se. However, those changes were not necessary as the testswere not failing because of the missing "assets" config, but due to anissue introduced in the Config component. Furthermore, removing thispart of the config fixtures gives us the benefit that our beforenormalization logic that enables assets support when the templatingintegration is enabled is properly tested.Commits-------fb1be51 revert useless tests fixtures changes
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failing tests relied on the assets integration being enabled. Since
we never did enable this explicitly, the assets related definitions are
removed now that#25789 was merged whichfixed#25760.