Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DoctrineBridge] Fix bug when indexBy is meta key in PropertyInfo\DoctrineExtractor#25841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:2.8frominsekticid:patch-1
Apr 20, 2018

Conversation

@insekticid
Copy link
Contributor

@insekticidinsekticid commentedJan 18, 2018•
edited by nicolas-grekas
Loading

QA
Branch?2.8
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#25834
LicenseMIT

@dunglas could you check it?

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedJan 21, 2018•
edited
Loading

@insekticid would you mind adding a test case please?

Status: needs work

Copy link
Member

@dunglasdunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

When a test will be added.

@fabpot
Copy link
Member

@insekticid Can you work on adding a test case for your bug fix? That's something we need to avoid future regression. Or do you need help?

@nicolas-grekas
Copy link
Member

Status: needs work
(missing test case)

@insekticid
Copy link
ContributorAuthor

I need some time to go back to this issue and write some tests

@insekticidinsekticidforce-pushed thepatch-1 branch 4 times, most recently from05a9d10 tofb8fe4bCompareMarch 30, 2018 23:14
@insekticid
Copy link
ContributorAuthor

insekticid commentedMar 31, 2018•
edited
Loading

added tests

@dunglas ping

@Simperfit
Copy link
Contributor

Travis failure is unrelated.

Status: Needs Review

Copy link
Contributor

@SimperfitSimperfit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@nicolas-grekasnicolas-grekas changed the titlePropertyInfo\DoctrineExtractor - There is bug when indexBy is meta key[DoctrineBridge] Fix bug when indexBy is meta keyApr 14, 2018
@nicolas-grekasnicolas-grekas changed the title[DoctrineBridge] Fix bug when indexBy is meta key[DoctrineBridge] Fix bug when indexBy is meta key in PropertyInfo\DoctrineExtractorApr 14, 2018
@fabpot
Copy link
Member

Isn't it something that also needs to be fixed in 2.8?

@nicolas-grekas
Copy link
Member

Thank you@insekticid.

@nicolas-grekasnicolas-grekas merged commit583759f intosymfony:2.8Apr 20, 2018
nicolas-grekas added a commit that referenced this pull requestApr 20, 2018
…rtyInfo\DoctrineExtractor (insekticid)This PR was submitted for the 3.4 branch but it was merged into the 2.8 branch instead (closes#25841).Discussion----------[DoctrineBridge] Fix bug when indexBy is meta key in PropertyInfo\DoctrineExtractor| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass?   | yes| Fixed tickets |#25834 <!-- #-prefixed issue number(s), if any -->| License       | MIT@dunglas could you check it?<!--- Bug fixes must be submitted against the lowest branch where they apply  (lowest branches are regularly merged to upper ones so they get the fixes too).- Features and deprecations must be submitted against the master branch.- Replace this comment by a description of what your PR is solving.-->Commits-------583759f PropertyInfo\DoctrineExtractor - There is bug when indexBy is meta key
@nicolas-grekasnicolas-grekas modified the milestones:3.4,2.8Apr 20, 2018
This was referencedApr 30, 2018
@insekticidinsekticid deleted the patch-1 branchMarch 1, 2021 12:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dunglasdunglasdunglas approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@SimperfitSimperfitSimperfit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

2.8

Development

Successfully merging this pull request may close these issues.

7 participants

@insekticid@nicolas-grekas@fabpot@Simperfit@dunglas@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp