Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Make session-related services extra-lazy#25836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedJan 18, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
5a9272e tofa4864aCompare| protectedfunctiongetSession() | ||
| { | ||
| if (!$this->container->has('session')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
$this->container can be null now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
good catch, fixed
f7ae524 to8600644Compare8600644 to5f53558Compare
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
closures could have some typehints/return types
| class SessionListenerextends AbstractSessionListener | ||
| { | ||
| private$container; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why is it removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
moved to the parent
fabpot commentedJan 23, 2018
Thank you@nicolas-grekas. |
…(nicolas-grekas)This PR was merged into the 4.1-dev branch.Discussion----------[HttpKernel] Make session-related services extra-lazy| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Commits-------5f53558 [HttpKernel] Make session-related services extra-lazy
This PR was merged into the 4.4 branch.Discussion----------[HttpKernel] Remove Symfony 3 compatibility code| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#38892| License | MIT| Doc PR | N/AThis PR removes dead code that checks for the presence of the `Request::setSessionFactory()` method.That method was added with#25836 in HttpFoundation 4.1. Since HttpKernel requires at least HttpFoundation 4.4, we can assume that the method is always present and thus simplify some code here.Additionally, I also fix the doc block as described in#38892. 😉Commits-------b9ca866 Remove Symfony 3 compatibility code.