Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] DebugHandlersListener should always replace the existing exception handler#25835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
linaori commentedJan 18, 2018
Fixes the scenario in prod mode with both the exception and error handlers pre-set, awesome! ❤️ |
45121bd toa8dc27bComparechalasr approved these changesJan 18, 2018
b6fc69e to0c0dd33CompareMemberAuthor
nicolas-grekas commentedJan 18, 2018
HHVM failure fixed by adding a new exclusion group, to allow easily reproducing the issue whilefacebook/hhvm#8107 is open. |
nicolas-grekas added a commit that referenced this pull requestJan 18, 2018
…he existing exception handler (nicolas-grekas)This PR was merged into the 2.7 branch.Discussion----------[HttpKernel] DebugHandlersListener should always replace the existing exception handler| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#25827| License | MIT| Doc PR | -The current logic is inconsistent because replacing or not depends whether an ExceptionHandler is registered or not.Embeds tests for the previous PR on the same topic, Debug component's side.Commits-------a4ddcc2 [HttpKernel] DebugHandlersListener should always replace the existing exception handler
This was referencedJan 29, 2018
Merged
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The current logic is inconsistent because replacing or not depends whether an ExceptionHandler is registered or not.
Embeds tests for the previous PR on the same topic, Debug component's side.