Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Debug] Always decorate existing exception handlers to deal with fatal errors#25829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.7fromnicolas-grekas:debug-x
Jan 18, 2018

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?2.7
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#25827
LicenseMIT
Doc PR-

Decorating the exception is seamless, let's always do it and fix handling of fatal errors.
Related to#25408 also.

@linaori
Copy link
Contributor

Verified the fix locally by doingset_error_handler('var_dump'); inapp.php, seems to work now 👍

@linaori
Copy link
Contributor

Small update:set_exception_handler('var_dump'); gives me

/home/ivanderberg/projects/mijn/www/vendor/symfony/debug/ErrorHandler.php:541:object(Symfony\Component\Debug\Exception\FatalErrorException)[3806]  protected 'message' => string 'Error: Uncaught ArgumentCountError: Too few arguments to function Symfony\Component\Debug\ErrorHandler::handleError(), 1 passed and exactly 4 expected in /home/ivanderberg/projects/mijn/www/vendor/symfony/debug/ErrorHandler.php:369Stack trace:#0 [internal function]: Symfony\Component\Debug\ErrorHandler->handleError(Object(TypeError))#1 {main}  thrown' (length=356)  private 'string' (Exception) => string '' (length=0)  protected 'code' => int 0  protected 'file' => string '/home/ivanderberg/projects/mijn/www/vendor/symfony/debug/ErrorHandler.php' (length=73)  protected 'line' => int 369  private 'trace' (Exception) =>     array (size=0)      empty  private 'previous' (Exception) => null  protected 'severity' => int 1

@nicolas-grekas
Copy link
MemberAuthor

Fixed thanks!

@linaori
Copy link
Contributor

@fabpot note that the current state does not work withset_exception_handler('var_dump');.

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit205d7ae intosymfony:2.7Jan 18, 2018
fabpot added a commit that referenced this pull requestJan 18, 2018
…l with fatal errors (nicolas-grekas)This PR was merged into the 2.7 branch.Discussion----------[Debug] Always decorate existing exception handlers to deal with fatal errors| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#25827| License       | MIT| Doc PR        | -Decorating the exception is seamless, let's always do it and fix handling of fatal errors.Related to#25408 also.Commits-------205d7ae [Debug] Always decorate existing exception handlers to deal with fatal errors
nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull requestJan 18, 2018
…handlers to deal with fatal errors (nicolas-grekas)"This reverts commit78a8a63, reversingchanges made to5d39415.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@linaori@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp