Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fixing a bug where the dump() function depended on bundle ordering#25824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas approved these changesJan 17, 2018
fabpot approved these changesJan 17, 2018
Member
fabpot commentedJan 17, 2018
Thank you@weaverryan. |
fabpot added a commit that referenced this pull requestJan 17, 2018
…ordering (weaverryan)This PR was merged into the 2.7 branch.Discussion----------Fixing a bug where the dump() function depended on bundle ordering| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | not neededIf DebugBundle is registered *before* TwigBundle, then the simpler `dump()` function wins over the fancy, var-dumper one from DebugBundle. In other words, you get different functionality based on the *order* in which you install libraries. To get the "bad" way, you can:```composer create-project symfony/skeleton show_bad_dumpcd show_bad_dumpcomposer require symfony/debug-bundlecomposer require twig```Then create a Twig template with a `dump()` inside. It will use the less-fancy XDebug version.I'm not sure if there's a more elegant fix for this or not... I have verified locally that this DOES fix the issue.Thanks!Commits-------717663a Fixing a bug where the dump() function depended on bundle ordering
This was referencedJan 29, 2018
Merged
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If DebugBundle is registeredbefore TwigBundle, then the simpler
dump()function wins over the fancy, var-dumper one from DebugBundle. In other words, you get different functionality based on theorder in which you install libraries. To get the "bad" way, you can:Then create a Twig template with a
dump()inside. It will use the less-fancy XDebug version.I'm not sure if there's a more elegant fix for this or not... I have verified locally that this DOES fix the issue.
Thanks!