NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Router] Skip anonymous classes when loading annotated routes#25801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

pierredup wants to merge2 commits intosymfony:2.7frompierredup:anonymous-class-in-trait

Closed

[Router] Skip anonymous classes when loading annotated routes#25801

pierredup wants to merge2 commits intosymfony:2.7frompierredup:anonymous-class-in-trait

Conversation

Copy link

Contributor

pierredup commentedJan 15, 2018•
edited
Loading

Q	A
Branch?	2.7
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#25796
License	MIT
Doc PR

Skip any usage of anonymous classes when parsing files inAnnotationFileLoader

carsonbot added Status: Needs Review Routing Bug labels

Jan 15, 2018

pierredup force-pushed theanonymous-class-in-trait branch 3 times, most recently frome016c78 to91c878eCompare

January 15, 2018 20:40

Skip anonymous classes inside a trait when loading annotated routes

3a272b2

pierredup force-pushed theanonymous-class-in-trait branch frome6cb583 to3a272b2Compare

January 16, 2018 06:57

javiereguiluz reviewed

Jan 16, 2018

View reviewed changes

src/Symfony/Component/Routing/Loader/AnnotationFileLoader.php Outdated

		// Skip usage of ::class constant
		$isClassConstant =false;
		// Skip usage of ::class constant and anonymous classes
		$isValidClass =true;

Copy link

Member

javiereguiluzJan 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not sure about this variable name ->$isValidClass because an anonymous class is a valid class.

Copy link

ContributorAuthor

pierredupJan 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I was mostly trying to avoid usingisClassConstantOrAnonymousClass andisValidClass is the first thing that came to mind. I'll change it to something more reasonable

Rename isValidClass variable

72576ba

stof approved these changes

Jan 16, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jan 16, 2018

javiereguiluz approved these changes

Jan 16, 2018

View reviewed changes

xabbuh approved these changes

Jan 16, 2018

View reviewed changes

nicolas-grekas added this to the2.7 milestone

Jan 16, 2018

Copy link

Member

nicolas-grekas commentedJan 16, 2018

Thank you@pierredup.

nicolas-grekas added a commit that referenced this pull request

Jan 16, 2018

bug#25801[Router] Skip anonymous classes when loading annotated rou…

01de7ad

…tes (pierredup)This PR was squashed before being merged into the 2.7 branch (closes#25801).Discussion----------[Router] Skip anonymous classes when loading annotated routes| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#25796| License       | MIT| Doc PR        |Skip any usage of anonymous classes when parsing files in `AnnotationFileLoader`Commits-------d76a545 [Router] Skip anonymous classes when loading annotated routes