Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fixed Request::__toString ignoring cookies#25799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
d2facb2 to8d1ddf5Compare
phansys left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Status: Needs work.
| $cookies[] =$k.'='.$v; | ||
| } | ||
| if (0 !==count($cookies)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please, use!empty() instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah, I like type safety but fixed :-)
fabpot commentedJan 16, 2018
Thank you@Toflar. |
This PR was squashed before being merged into the 2.7 branch (closes#25799).Discussion----------Fixed Request::__toString ignoring cookies| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |`Request::__toString()` ignored cookie values which caused me some headaches during a debugging session 😄Commits-------0f79d09 Fixed Request::__toString ignoring cookies
Request::__toString()ignored cookie values which caused me some headaches during a debugging session 😄