Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Add placeholder for line number in console exception fixtures#25794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
pierredup commentedJan 15, 2018
Travis HHVM failure seems unrelated |
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would have just changedassertStringEqualsFile toassertStringMatchesFormatFile(), replacing the line number by%d in fixtures (https://phpunit.de/manual/current/en/appendixes.assertions.html#appendixes.assertions.assertStringMatchesFormatFile). Feel free to update if you want, fine for me as is. Thanks for taking care
pierredup commentedJan 15, 2018
I think |
chalasr commentedJan 15, 2018
Thank you@pierredup. |
…eption fixtures (pierredup)This PR was squashed before being merged into the 3.4 branch (closes#25794).Discussion----------[Console] Add placeholder for line number in console exception fixtures| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Add placeholders for exception line numbers for tests in `ApplicationTest` to make the tests more flexibleCommits-------686d4f7 [Console] Add placeholder for line number in console exception fixtures
Add placeholders for exception line numbers for tests in
ApplicationTestto make the tests more flexible