Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] 19 digits VISA card numbers are valid#25771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| '/^5[1-5][0-9]{14}$/', | ||
| '/^2(22[1-9][0-9]{12}|2[3-9][0-9]{13}|[3-6][0-9]{14}|7[0-1][0-9]{13}|720[0-9]{12})$/', | ||
| ), | ||
| // All Visa card numbers start with a 4. New cards have 16 digits. Old cards have 13. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Comment should be removed or updated as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
comment updated
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@xabbuh thank you for fixing this error. Please, don't forget to update the comment too. Thanks!
fabpot commentedJan 13, 2018
Thank you@xabbuh. |
This PR was merged into the 2.7 branch.Discussion----------[Validator] 19 digits VISA card numbers are valid| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |some sources:*https://en.wikipedia.org/wiki/Payment_card_number*https://blog.vindicia.com/19-digit-visas-and-2-digit-mastercards/*https://www.nccgroup.trust/de/uber-uns/newsroom-and-events/blogs/2016/november/prepare-for-19-digit-credit-cards/*http://support.worldpay.com/support/kb/bg/testandgolive/tgl5103.htmlCommits-------a53cc5c 19 digits VISA card numbers are valid
some sources: