Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] add autowiring aliases for TranslationReaderInterface, ExtractorInterface & TranslationWriterInterface#25701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Nijusan
Copy link

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#25679
LicenseMIT
Doc PR

Supporting#25679

@chalasr
Copy link
Member

We already merged similar changes as features and others as bug fixes on 3.4. What should be the rule? I think it's fine as a bug fix.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd prefer master as is now, to move 3.4 to strictly bug fixes. But if you have arguments for 3.4, I won't really object personally.

@chalasrchalasr added this to the4.1 milestoneJan 6, 2018
@nicolas-grekasnicolas-grekas changed the titleadding interface alias for reader, writer and extractor[FrameworkBundle] add autowiring aliases for TranslationReaderInterface, ExtractorInterface & TranslationWriterInterfaceJan 7, 2018
@nicolas-grekas
Copy link
Member

Thank you@Nijusan.

@nicolas-grekasnicolas-grekas merged commite2ddc17 intosymfony:masterJan 7, 2018
nicolas-grekas added a commit that referenced this pull requestJan 7, 2018
…onReaderInterface, ExtractorInterface & TranslationWriterInterface (Dennis Langen)This PR was merged into the 4.1-dev branch.Discussion----------[FrameworkBundle] add autowiring aliases for TranslationReaderInterface, ExtractorInterface & TranslationWriterInterface| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#25679| License       | MIT| Doc PR        |Supporting#25679Commits-------e2ddc17 adding interface alias for reader, writer and extractor
@fabpotfabpot mentioned this pull requestMay 7, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Nijusan@chalasr@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp