Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix bug #25665: Type of column for timestamp changed to signed#25667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedJan 3, 2018
this will not fix the issue for people that already have created the table |
nicolas-grekas commentedJan 16, 2018
ping@WhiteEagle88 ? Status: needs work |
| // delete the session records that have expired | ||
| $sql ="DELETE FROM$this->table WHERE$this->lifetimeCol < :time -$this->timeCol"; | ||
| $sql ="DELETE FROM$this->table WHERE$this->lifetimeCol < :time -CAST($this->timeCol AS SIGNED)"; |
nicolas-grekasJan 21, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
would it make sense to just change this to$this->lifetimeCol + $this->timeCol < :time? (thus revert the change on the "create table")
nicolas-grekas commentedJan 25, 2018
Closing in favor of#25922, thanks for proposing. |
Fix PDO session timestamp out of range for MySQL