Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Dumper shouldn't use html format for phpdbg#25662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz commentedJan 3, 2018
Inother parts of Symfony we have this: in_array(PHP_SAPI,array('cli','cli-server','phpdbg')) Should we use the same here? |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
for 2.7
nicolas-grekas commentedJan 3, 2018
@javiereguiluz cli-server means HTML should be used |
nicolas-grekas commentedJan 3, 2018
Thank you@jhoff. |
…jhoff)This PR was submitted for the 3.3 branch but it was merged into the 2.7 branch instead (closes#25662).Discussion----------Dumper shouldn't use html format for phpdbg / cli-server| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aThis may not be the lowest branch that this fix applies to.Prevents the dumper from outputting in html format when using phpdbg.Commits-------e2b6091 Dumper shouldn't use html format for phpdbg
jhoff commentedJan 3, 2018
Awesome. Also, sorry, I originally had cli-server in there but decided to take it out for the reason stated above. I then forgot to edit the title of the merge request. |
This may not be the lowest branch that this fix applies to.
Prevents the dumper from outputting in html format when using phpdbg.