Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Fixed BC bug when mixing short & long options#25574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Simperfit commentedDec 21, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Can you post a reproducer ? becausehttps://github.com/symfony/symfony/pull/25487/files#diff-3ae4ec9ae7b044c86a061156979d87fbR287 does fix this behaviour. if you remove the explode then it shows the shell, with the explode it does not. So I think this check is useless. |
| if (0 ===strpos($token,'-') &&0 !==strpos($token,'--')) { | ||
| $noValue =explode('=',$token); | ||
| $token =$noValue[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This does it already.
stloyd commentedDec 21, 2017
@Simperfit Right, looks like this is duplicate then. Closing. |
PR#25487 introduced BC break when call to command was mixing both, short & long options.
v2.7.38(notice-e=testat end):v2.7.39: