Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] Fixed BC bug when mixing short & long options#25574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
stloyd wants to merge1 commit intosymfony:2.7fromstloyd:patch-6

Conversation

@stloyd
Copy link
Contributor

QA
Branch?2.7+
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
LicenseMIT

PR#25487 introduced BC break when call to command was mixing both, short & long options.

v2.7.38 (notice-e=test at end):

$ app/console cache:warmup --no-ansi --no-interaction --no-debug -e=test // Warming up the cachefor thetest environment with debugfalse [OK] Cachefor the"test" environment (debug=false) was successfully warmed.

v2.7.39:

$ app/console cache:warmup --no-ansi --no-interaction --no-debug -e=test      _____                  __     / ____|                / _|| (___  _   _ _ __ ___||_ ___  _ __  _   _\___\||||'_ ` _ \|  _/ _ \|'_\||||     ____)||_||||||||| (_)|||||_|||_____/\__,|_||_||_|_|\___/|_||_|\__,|             __/|                          __/||___/|___/Welcome to the Symfony shell (2.8.32 - app/test).At the prompt,typehelpfor some help,or list to get a list of available commands.Toexit the shell,type ^D.Symfony>

@Simperfit
Copy link
Contributor

Simperfit commentedDec 21, 2017
edited
Loading

Can you post a reproducer ? becausehttps://github.com/symfony/symfony/pull/25487/files#diff-3ae4ec9ae7b044c86a061156979d87fbR287 does fix this behaviour.

if you remove the explode then it shows the shell, with the explode it does not.

So I think this check is useless.


if (0 ===strpos($token,'-') &&0 !==strpos($token,'--')) {
$noValue =explode('=',$token);
$token =$noValue[0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This does it already.

@stloyd
Copy link
ContributorAuthor

@Simperfit Right, looks like this is duplicate then. Closing.

@stloydstloyd closed thisDec 21, 2017
@stloydstloyd deleted the patch-6 branchDecember 21, 2017 15:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@SimperfitSimperfitSimperfit left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

4 participants

@stloyd@Simperfit@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp