Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Process] Dont use getenv(), it returns arrays and can introduce subtle breaks accros PHP versions#25559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.3fromnicolas-grekas:proc-no-getenv
Dec 20, 2017

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?3.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#25511
LicenseMIT
Doc PR-

ludo237 reacted with thumbs up emoji
@chr-hertel
Copy link
Member

thanks@nicolas-grekas! fixes the issue in our project, just tested it 👍

@nicolas-grekasnicolas-grekas merged commit0d4bce6 intosymfony:3.3Dec 20, 2017
nicolas-grekas added a commit that referenced this pull requestDec 20, 2017
…roduce subtle breaks accros PHP versions (nicolas-grekas)This PR was merged into the 3.3 branch.Discussion----------[Process] Dont use getenv(), it returns arrays and can introduce subtle breaks accros PHP versions| Q             | A| ------------- | ---| Branch?       | 3.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#25511| License       | MIT| Doc PR        | -Commits-------0d4bce6 [Process] Dont use getenv(), it returns arrays and can introduce subtle breaks accros PHP versions
@nicolas-grekasnicolas-grekas deleted the proc-no-getenv branchDecember 20, 2017 12:21
@ghost
Copy link

ghost commentedDec 27, 2017•
edited by ghost
Loading

this bug also occurs in 3.4

n-sviridenko reacted with thumbs up emoji

@nicolas-grekas
Copy link
MemberAuthor

@WPPD 3.3 will be merged into 3.4 if not already the case, so all upper branches will get the fix before next release.

@n-sviridenko
Copy link

The fix is not merged yet. Is there any workaround applicable?

@xabbuh
Copy link
Member

@n-sviridenko In the meantime it seems to have been merged up tomaster.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

6 participants

@nicolas-grekas@chr-hertel@n-sviridenko@xabbuh@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp