Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Fix panel break when stopwatch component is not installed.#25526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| {%setsubrequests_time=subrequests_time+ child.getcollector('time').events.__section__.duration %} | ||
| {%endfor %} | ||
| {%else %} | ||
| {%setsubrequests_time=0 %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should it be n/a?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The profiler panel shows 0 for all time values, only the toolbar shows n/a. I can change it to be n/a for all values if you like it better. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"n/a" looks better to me
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(with minor comment)
javiereguiluz commentedDec 28, 2017
@umulmrum thanks for fixing this bug and congrats on your first Symfony contribution! |
…nt is not installed. (umulmrum, javiereguiluz)This PR was merged into the 3.4 branch.Discussion----------[WebProfilerBundle] Fix panel break when stopwatch component is not installed.| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#25350| License | MIT| Doc PR | -Fixes a crash in the time profiler panel when the stopwatch is not installed. This avoids a hard dependency like the ticket author requested, as the rest of the component can already deal with that case.I think this is an issue in 3.4+, but I only tested against 4.0.2 locally (code in the affected file only differs in whitespace between 3.4 and 4.0).Commits-------e9577cb Display n/a for sub-requests time when Stopwatch component is not installed410b597 Fix panel break when stopwatch component is not installed.
…component is not installed. (umulmrum, javiereguiluz)This PR was merged into the 3.4 branch.Discussion----------[WebProfilerBundle] Fix panel break when stopwatch component is not installed.| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |symfony#25350| License | MIT| Doc PR | -Fixes a crash in the time profiler panel when the stopwatch is not installed. This avoids a hard dependency like the ticket author requested, as the rest of the component can already deal with that case.I think this is an issue in 3.4+, but I only tested against 4.0.2 locally (code in the affected file only differs in whitespace between 3.4 and 4.0).Commits-------e9577cb Display n/a for sub-requests time when Stopwatch component is not installed410b597 Fix panel break when stopwatch component is not installed.
Fixes a crash in the time profiler panel when the stopwatch is not installed. This avoids a hard dependency like the ticket author requested, as the rest of the component can already deal with that case.
I think this is an issue in 3.4+, but I only tested against 4.0.2 locally (code in the affected file only differs in whitespace between 3.4 and 4.0).