Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PropertyAccess] add more information to NoSuchPropertyException Message#25450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Simperfit
Copy link
Contributor

QA
Branch?4.1
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?no
Fixed tickets#24742
LicenseMIT
Doc PR

Add more context to NoSuchPropertyException as discussed in the issue.

@SimperfitSimperfitforce-pushed thefeature/improve-the-property-writeProperty-error branch 4 times, most recently fromb67d768 to590dc8aCompareDecember 11, 2017 20:42
@chalasrchalasr added this to the4.1 milestoneDec 11, 2017
@SimperfitSimperfitforce-pushed thefeature/improve-the-property-writeProperty-error branch from590dc8a tof835e19CompareDecember 11, 2017 20:45
@SimperfitSimperfitforce-pushed thefeature/improve-the-property-writeProperty-error branch fromf835e19 todee00f8CompareDecember 11, 2017 22:43
@Simperfit
Copy link
ContributorAuthor

fabbot failure is a false positive.

@Koc
Copy link
Contributor

Koc commentedDec 12, 2017•
edited
Loading

Why not cover this change with test using@expectedException?

@Simperfit
Copy link
ContributorAuthor

Simperfit commentedDec 12, 2017 via email

Because I did not find an easy way to do it. But I can look into it to addoneLe mar. 12 déc. 2017 à 17:13, Konstantin Myakshin <notifications@github.com>a écrit :
…
Why not cover this change with test using expectsException? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#25450 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADSq8tximFTQC2YdXN4ZHERAOCJ5e_bVks5s_qZGgaJpZM4Q9_yn> .

@fabpot
Copy link
Member

Thank you@Simperfit.

@fabpotfabpot merged commitdee00f8 intosymfony:masterDec 14, 2017
fabpot added a commit that referenced this pull requestDec 14, 2017
…yException Message (Simperfit)This PR was merged into the 4.1-dev branch.Discussion----------[PropertyAccess] add more information to NoSuchPropertyException Message| Q             | A| ------------- | ---| Branch?       | 4.1| Bug fix?      | no| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass?   | no| Fixed tickets |#24742| License       | MIT| Doc PR        |Add more context to NoSuchPropertyException as discussed in the issue.Commits-------dee00f8 [PropertyAccess] add more information to NoSuchPropertyException Message
@fabpotfabpot mentioned this pull requestMay 7, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@dunglasdunglasdunglas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

6 participants

@Simperfit@Koc@fabpot@dunglas@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp