Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Fix Image/SVG display in WebProfiler toolbar.#25433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice fix. Have you tried it in different popular browsers to be sure there are no side effects? Thanks!
bobdenotter commentedDec 11, 2017
Hi@javiereguiluz, good question. I confirmed the issue on Chrome, Firefox, Safari and MS Edge across OSX and Win10. This fix works on all tested browsers. |
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for fixing this and for testing it in all browsers!
… toolbar. (bobdenotter)This PR was merged into the 2.7 branch.Discussion----------[WebProfilerBundle] Fix Image/SVG display in WebProfiler toolbar.| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This small fix prevents widths from "creeping in" from previously defined CSS rules into the WebProfiler toolbar. See before/after screenshot:Note: This PR fixes an other issue than#18469, which landed in SF 2.8.Commits-------62f5eae Set `width: auto` on WebProfiler toolbar's reset.
This small fix prevents widths from "creeping in" from previously defined CSS rules into the WebProfiler toolbar. See before/after screenshot:
Note: This PR fixes an other issue than#18469, which landed in SF 2.8.