Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fixes for Oracle in PdoSessionHandler#25430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
elislenio commentedDec 11, 2017
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18305 |
| License | MIT |
| Doc PR |
| "WHEN NOT MATCHED THEN INSERT ($this->idCol,$this->dataCol,$this->lifetimeCol,$this->timeCol) VALUES (?, ?, ?, ?)". | ||
| "WHEN MATCHED THEN UPDATE SET$this->dataCol = ?,$this->lifetimeCol = ?,$this->timeCol = ?"; | ||
| // MERGE is not supported with LOBs: http://www.oracle.com/technetwork/articles/fuecks-lobs-095315.html | ||
| returnnull; |
nicolas-grekasDec 11, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
not sure this is correct: you want $mergeSql to be null and to break out of the switch, but still have the next lines executed, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OK, nevermind :)
But you can remove the next line (the break)
fabpot commentedDec 31, 2017
Thank you@elislenio. |
This PR was squashed before being merged into the 2.7 branch (closes#25430).Discussion----------Fixes for Oracle in PdoSessionHandler| Q | A| ------------- | ---| Branch? | 2.7 <!-- see below -->| Bug fix? | yes| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets |#18305 <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | <!--highly recommended for new features--><!--Fixes missing session data for Oracle in PdoSessionHandler-->Commits-------e7a4002 Fixes for Oracle in PdoSessionHandler