Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Remove group options without data on debug:form command#25404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromyceruto:debug_form_bug
Dec 31, 2017

Conversation

@yceruto
Copy link
Member

@ycerutoyceruto commentedDec 8, 2017•
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#25394
LicenseMIT
Doc PR-

This also fix the normalization of the options column for text descriptor, regardless of changes incollectOptions() method (which is enough to fix the related bug).

@maidmaid could you confirm if these changes solve the problem?

@yceruto
Copy link
MemberAuthor

(Travis failure unrelated)

@stof
Copy link
Member

stof commentedDec 8, 2017

this will remove also options with afalse value for instance, which looks bad

@yceruto
Copy link
MemberAuthor

yceruto commentedDec 8, 2017•
edited
Loading

this will remove also options with a false value for instance, which looks bad

@stof no, this is a list of defined options only, i.e they are names (strings).

@maidmaid
Copy link
Contributor

I just applied your patch, and yes it works.

@yceruto
Copy link
MemberAuthor

@maidmaid thanks!

Copy link
Contributor

@SimperfitSimperfit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Travis failure in unrelated

@chalasr
Copy link
Member

@yceruto Could you add a test case to prevent regressions?

Simperfit and yceruto reacted with thumbs up emoji

@yceruto
Copy link
MemberAuthor

Test added (still failure is unrelated)

@fabpot
Copy link
Member

Thank you@yceruto.

@fabpotfabpot merged commit083c8af intosymfony:3.4Dec 31, 2017
fabpot added a commit that referenced this pull requestDec 31, 2017
…mand (yceruto)This PR was merged into the 3.4 branch.Discussion----------[Form] Remove group options without data on debug:form command| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#25394| License       | MIT| Doc PR        | -This also fix the normalization of the options column for text descriptor, regardless of changes in `collectOptions()` method (which is enough to fix the related bug).@maidmaid could you confirm if these changes solve the problem?Commits-------083c8af Remove group options without data and fix normalization
@ycerutoyceruto deleted the debug_form_bug branchJanuary 2, 2018 17:23
@fabpotfabpot mentioned this pull requestJan 5, 2018
@fabpotfabpot mentioned this pull requestJan 5, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@chalasrchalasrchalasr approved these changes

+2 more reviewers

@ogizanagiogizanagiogizanagi approved these changes

@SimperfitSimperfitSimperfit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

8 participants

@yceruto@stof@maidmaid@chalasr@fabpot@ogizanagi@Simperfit@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp