Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpFoundation] Fixed default user-agent (3.X -> 4.X)#25392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.0fromlyrixx:user-agent
Dec 8, 2017

Conversation

@lyrixx
Copy link
Member

QA
Branch?4.0
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#25390
LicenseMIT
Doc PR

'SERVER_PORT' =>80,
'HTTP_HOST' =>'localhost',
'HTTP_USER_AGENT' =>'Symfony/3.X',
'HTTP_USER_AGENT' =>'Symfony/4.X',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

...and the usual question when we do changes like this: can we remove the version number? would it make sense to do that? is it valid as a User Agent string?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 for removing the version

@nicolas-grekas
Copy link
Member

Why remove the version number?
For reference, we changed from 2 to 3 without much discussion in#17340
So let's have a real discussion now?
To me, the version seems legit as it provides a hint that could be useful.
I wouldn't mind either removing it, but why in the first place?

@lyrixx
Copy link
MemberAuthor

Actually I really don't care. I removed it as@javiereguiluz suggested it in order to ease maintenance.
More over this value is almost useless, as it's a default value that is almost every-time overrided. I don't really see when this value could give an hint. You may be confused because of theBrowserKit Client ?

Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Removing the version seems the right thing to do.

@nicolas-grekas
Copy link
Member

Thank you@lyrixx.

@nicolas-grekasnicolas-grekas merged commitac007e1 intosymfony:4.0Dec 8, 2017
nicolas-grekas added a commit that referenced this pull requestDec 8, 2017
…rixx)This PR was merged into the 4.0 branch.Discussion----------[HttpFoundation] Fixed default user-agent (3.X -> 4.X)| Q             | A| ------------- | ---| Branch?       | 4.0| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#25390| License       | MIT| Doc PR        |Commits-------ac007e1 [HttpFoundation] Fixed default user-agent (3.X -> 4.X)
@lyrixxlyrixx deleted the user-agent branchDecember 8, 2017 17:23
@javiereguiluzjaviereguiluz mentioned this pull requestDec 9, 2017
@fabpotfabpot mentioned this pull requestDec 15, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

@fabpotfabpotfabpot approved these changes

+2 more reviewers

@issei-missei-missei-m approved these changes

@SimperfitSimperfitSimperfit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

7 participants

@lyrixx@nicolas-grekas@fabpot@javiereguiluz@issei-m@Simperfit@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp