Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Fix circular-aliases message#25382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| if (isset($seen[$id])) { | ||
| thrownewServiceCircularReferenceException($id,array_keys($seen)); | ||
| $seen =array_values($seen); | ||
| $seen =array_slice($seen,array_search($id,$seen)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the slicing part is not covered by the test (as the tests cover only the case where the loop starts at the beginning of the list).
Can you add another test covering this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
test updated
This PR was merged into the 3.3 branch.Discussion----------[DI] Fix circular-aliases message| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? || New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -The missing bits in#25364Commits-------f1a7b07 [DI] Fix circular-aliases message
yannickl88 commentedDec 11, 2017
man, been debugging the container for 2 hours. Applying this change showed me the issues and could solve it in 5 min. So...when will there be a release? 😇 |
The missing bits in#25364