Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Decouple exception logging from rendering#25366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedDec 14, 2017
Thank you@ro0NL. |
… (ro0NL)This PR was merged into the 4.1-dev branch.Discussion----------[HttpKernel] Decouple exception logging from rendering| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#25266| License | MIT| Doc PR | symfony/symfony-docs#... <!--highly recommended for new features-->Given your controller throws an exception and a custom exception listener sets a response.BeforeAfter;-)edit: raising the priority for the profiler listener fixes the exception panel also.Commits-------a203d31 [HttpKernel] Decouple exception logging from rendering
sroze commentedDec 14, 2017
Nice@ro0NL 👍 |
| 4.1.0 | ||
| ----- | ||
| *`ExceptionListener` now logs and collects exceptions at priority`2048` (previously logged at`-128` and collected at`0`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is it worth to add this to the upgrade file too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What exactly needs an upgrade step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I was thinking about other listeners that relied on this one being executed before/after themselves. Probably an edge case though that's not needed to be tackled.
Uh oh!
There was an error while loading.Please reload this page.
Given your controller throws an exception and a custom exception listener sets a response.
Before
After
;-)
edit: raising the priority for the profiler listener fixes the exception panel also.