Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DoctrineBridge] DoctrineDataCollector comments the non runnable part of the query#25346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:masterfromSimperfit:bugfix/doctrine-data-collector-the-query-should-be-directly-runnableDec 7, 2017
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
Simperfit commentedDec 6, 2017
AppVeyor failure is unrelated, do you want me to push force to restart the build ? |
Contributor
ogizanagi commentedDec 6, 2017
@Simperfit: I've restarted it. |
Member
nicolas-grekas commentedDec 6, 2017
That's a feature, thus for master. |
ffc0b23 tof4998ebComparef4998eb to42760d0CompareContributorAuthor
Simperfit commentedDec 6, 2017
done@nicolas-grekas |
nicolas-grekas approved these changesDec 6, 2017
ContributorAuthor
Simperfit commentedDec 7, 2017
travis failure is unrelated |
fabpot approved these changesDec 7, 2017
Member
fabpot commentedDec 7, 2017
Thank you@Simperfit. |
fabpot added a commit that referenced this pull requestDec 7, 2017
…n runnable part of the query (Simperfit)This PR was merged into the 4.1-dev branch.Discussion----------[DoctrineBridge] DoctrineDataCollector comments the non runnable part of the query| Q | A| ------------- | ---| Branch? | 4.1| Bug fix? | yes| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets |#24782| License | MIT| Doc PR | symfony/symfony-docs#... <!--highly recommended for new features-->I think the idea in this ticket is good and it should be implemented. Could we go further by adding more things to this feature, or will it be ok to just comment out the un-needed part to make the kiri(french joke for query) runnable ?Commits-------42760d0 [DoctrineBridge] DoctrineDataCollector comments the non runnable part of the query
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I think the idea in this ticket is good and it should be implemented. Could we go further by adding more things to this feature, or will it be ok to just comment out the un-needed part to make the kiri
(french joke for query) runnable ?