Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] Adding a GuardAuthenticatorHandler alias#25274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Simperfit commentedDec 3, 2017
It seems that the file loader can't load the file anymore, could you please check why ? |
weaverryan commentedDec 3, 2017
@Simperfit yea, I borked it :). Let's try that again |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
3.4?
weaverryan commentedDec 4, 2017
Yea, it could be considered a bug fix: it reallyshould be usable by the end-user. When the service became private in 4.0, that made it not easily usable. So, I think 3.4 makes sense (we could do 3.3... but I don't want to make a policy of back-porting all aliases to 3.3: we just need to make sure they exist on 3.4 so people can upgrade) |
fabpot commentedDec 4, 2017
Thank you@weaverryan. |
…rryan)This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes#25274).Discussion----------[Security] Adding a GuardAuthenticatorHandler alias| Q | A| ------------- | ---| Branch? | master| Bug fix? | kinda| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | This feature is not currently documentedThe `security.authentication.guard_handler` service *is* actually meant to be available for users to use. Specifically, the `authenticateUserAndHandleSuccess()` method is useful to auto-login the user after, for example, registration, but maintain all the behavior of a normal login (success behavior, trigger the login event).So, it should have an autowiring alias.Commits-------844c402 [Security] Adding a GuardAuthenticatorHandler alias
The
security.authentication.guard_handlerserviceis actually meant to be available for users to use. Specifically, theauthenticateUserAndHandleSuccess()method is useful to auto-login the user after, for example, registration, but maintain all the behavior of a normal login (success behavior, trigger the login event).So, it should have an autowiring alias.