Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] turn $private to protected in dumped container, to make cache:clear BC#25268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
e87c138 to4cfc753Comparedunglas approved these changesDec 2, 2017
chalasr approved these changesDec 2, 2017
fabpot requested changesDec 2, 2017
| private\$parameters; | ||
| private\$targetDirs = array(); | ||
| private\$privates = array(); | ||
| protected\$privates = array(); |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A small comment should be added to explain why this specific one is not private.
4cfc753 to4e493e6Compare4e493e6 toc98d967CompareMemberAuthor
nicolas-grekas commentedDec 3, 2017
Comment added. Status: needs review |
Simperfit approved these changesDec 3, 2017
fabpot approved these changesDec 4, 2017
stof approved these changesDec 4, 2017
Member
fabpot commentedDec 4, 2017
Thank you@nicolas-grekas. |
fabpot added a commit that referenced this pull requestDec 4, 2017
…ke cache:clear BC (nicolas-grekas)This PR was merged into the 4.0 branch.Discussion----------[DI] turn $private to protected in dumped container, to make cache:clear BC| Q | A| ------------- | ---| Branch? | 4.0| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Turning this property to protected changes nothing to its visibility in practice as the class is final anyway,but when migrating to SF4.0 from 3.4, the `cache:clear` command chokes with "Compile Error: Access level to srcDevDebugProjectContainer::$privates must be protected".Let's make it protected to remove this WTF.Commits-------c98d967 [DI] turn $private to protected in dumped container, to make cache:clear BC
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Turning this property to protected changes nothing to its visibility in practice as the class is final anyway,
but when migrating to SF4.0 from 3.4, the
cache:clearcommand chokes with "Compile Error: Access level to srcDevDebugProjectContainer::$privates must be protected".Let's make it protected to remove this WTF.