Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Stop DebugHandler silencing errors#25234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ostrolucky wants to merge1 commit intosymfony:2.7fromostrolucky:patch-12

Conversation

@ostrolucky
Copy link
Contributor

@ostroluckyostrolucky commentedNov 30, 2017
edited
Loading

QA
Branch?2.7
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#8703
LicenseMIT
Doc PR

I don't know if this is best fix for the issue, but I want to get things moving here. ErrorHandler silencing errors has been rampant in Symfony for years. Can be reproduced easily, dunno why there isn't more traction in fixing this.

The line I am removing has been introduced in#10921, I didn't find explanation why though.
Will add test case if this approach is approved.

theofidry and Koc reacted with thumbs up emoji
@nicolas-grekas
Copy link
Member

Errors are silenced by default so that no bad info can leak from broken apps.
We have plenty of mechanism that deal with reporting errors to users when appropriate.
Instead, we should fix these.

@ostrolucky
Copy link
ContributorAuthor

ostrolucky commentedDec 9, 2017
edited
Loading

Errors aren't silenced by default, only when Debug component is enabled. Since it's enabled by default inapp_dev only, this effectively means it silences errors for developers only. In production, it doesn't do silencing, because it's not enabled.Docs seem to have my back in this:

The Debug component provides tools to ease debugging PHP code.

You should never enable the debug tools in a production environment as they might disclose sensitive information to the user.

So I don't understand what's the issue with this patch, nor why was that line put there in the first place. It's really contraproductive. I want all errors shown when enabling this component. I don't want to be pushed to comment outDebug::enable() line in myindex.php each time I get blank page.

We have plenty of mechanism that deal with reporting errors to users when appropriate.
Instead, we should fix these.

Well I thought this is one of them and I am fixing it? You have better fix in mind for cases like I have shown in linked issue?

@nicolas-grekas
Copy link
Member

Here is the fix#25408
Thanks for the reproducer in#8703 (comment)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees

No one assigned

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

3 participants

@ostrolucky@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp