Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Stop DebugHandler silencing errors#25234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedDec 8, 2017
Errors are silenced by default so that no bad info can leak from broken apps. |
ostrolucky commentedDec 9, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Errors aren't silenced by default, only when Debug component is enabled. Since it's enabled by default inapp_dev only, this effectively means it silences errors for developers only. In production, it doesn't do silencing, because it's not enabled.Docs seem to have my back in this:
So I don't understand what's the issue with this patch, nor why was that line put there in the first place. It's really contraproductive. I want all errors shown when enabling this component. I don't want to be pushed to comment out
Well I thought this is one of them and I am fixing it? You have better fix in mind for cases like I have shown in linked issue? |
nicolas-grekas commentedDec 9, 2017
Here is the fix#25408 |
Uh oh!
There was an error while loading.Please reload this page.
I don't know if this is best fix for the issue, but I want to get things moving here. ErrorHandler silencing errors has been rampant in Symfony for years. Can be reproduced easily, dunno why there isn't more traction in fixing this.
The line I am removing has been introduced in#10921, I didn't find explanation why though.
Will add test case if this approach is approved.