Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Improve controller linking#25164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| <ahref="{{ path('_profiler', {token:child.token }) }}"> | ||
| {{ helper.set_handler(child.getcollector('request').controller) }} | ||
| </a> | ||
| {{ helper.set_handler(child.getcollector('request').controller) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
While at it; removed a useless outer link, as the actual (inner) link comes fromset_handler.
nicolas-grekas commentedNov 27, 2017
For master, that's not a bug but an improvement. |
ro0NL commentedNov 27, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
True, and i dont mind really. Just picked 3.3 so profiler templates stay in sync as much as possible. But im not sure that's a goal we should keep pursuing. And of course, curious what others think of the change / branch target. 2nd commit is for 3.3; ill create a new PR if needed. |
nicolas-grekas commentedFeb 4, 2018
please rebase/retarget for master |
ro0NL commentedFeb 5, 2018
@nicolas-grekas screenshots added in main post. |
fabpot commentedFeb 7, 2018
Thank you@ro0NL. |
This PR was merged into the 4.1-dev branch.Discussion----------[WebProfilerBundle] Improve controller linking| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes/no| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!--highly recommended for new features-->I propose to remove the `Controller class` entry from the request toolbar panel, IMHO it's confusing/useless compared to the linked `Controller` entry above. They represent the same.To preserve its value it's now used as title attribute instead, favored over controller file currently being used here. We can read that from the statusbar anyway :-)Before: (hovering ontroller link)After: (hovering ontroller link)Commits-------f6c0dc6 [WebProfilerBundle] Improve controller linking
This PR was submitted for the 3.3 branch but it was merged into the 3.4 branch instead (closes#26051).Discussion----------[WebProfilerBundle] Fix sub request link| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes/no| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!--highly recommended for new features-->Split from#25164before:```html<a href="/_profiler/395a5c"> <a href="/_profiler/open?file=symfony/src/Controller/MainController.php&line=20#line20" title="symfony/src/Controller/MainController.php">MainController :: bar</a></a><small>(token = <a href="/_profiler/395a5c">395a5c</a>)</small>```after:```html<a href="/_profiler/open?file=symfony/src/Controller/MainController.php&line=20#line20" title="symfony/src/Controller/MainController.php">MainController :: bar</a><small>(token = <a href="/_profiler/395a5c">395a5c</a>)</small>```Commits-------8f0e47f [WebProfilerBundle] Fix sub request link
Uh oh!
There was an error while loading.Please reload this page.
I propose to remove the
Controller classentry from the request toolbar panel, IMHO it's confusing/useless compared to the linkedControllerentry above. They represent the same.To preserve its value it's now used as title attribute instead, favored over controller file currently being used here. We can read that from the statusbar anyway :-)
Before: (hovering ontroller link)
After: (hovering ontroller link)