Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Fix tracking of env vars in exceptions#25163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[DI] Fix tracking of env vars in exceptions#25163
Uh oh!
There was an error while loading.Please reload this page.
Conversation
1f003f9 toa662881Comparea662881 to73f1ac5Compare| $tmpContainer =newContainerBuilder($resolvingBag); | ||
| $tmpContainer->setResourceTracking($container->isTrackingResources()); | ||
| $tmpContainer->addObjectResource($extension); | ||
| if ($extensioninstanceof ConfigurationExtensionInterface &&null !==$configuration =$extension->getConfiguration($config,$tmpContainer)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Assignment in condition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Indeed :) Was here before, and not forbidden by our policy, you can find many others in the code base.
| $extension->load($config,$tmpContainer); | ||
| $extension->load($config,$tmpContainer); | ||
| }catch (\Exception$e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Any chance to specify less general exception?
nicolas-grekasNov 26, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would be a bug.Could be "finally" in fact.
This PR was merged into the 3.3 branch.Discussion----------[DI] Fix tracking of env vars in exceptions| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24270,#24368| License | MIT| Doc PR | -Fixes the bad exception message reported in the linked issue (regression introduced in v3.3.7).Best reviewed [ignoring whitespaces](https://github.com/symfony/symfony/pull/25163/files?w=1).Commits-------73f1ac5 [DI] Fix tracking of env vars in exceptions
Uh oh!
There was an error while loading.Please reload this page.
Fixes the bad exception message reported in the linked issue (regression introduced in v3.3.7).
Best reviewedignoring whitespaces.