Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Pr/workflow name as graph label#25148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| ->setDefinition(array( | ||
| newInputArgument('name', InputArgument::REQUIRED,'A workflow name'), | ||
| newInputArgument('marking', InputArgument::IS_ARRAY,'A marking (a list of places)'), | ||
| newInputOption('workflow-name-label',null,null,'Labels graph with workflow name'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
what about--label | --label="value" api? Using workflow name as default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thx for your comment thats a very good idea. I will change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I updated my pull request now it's like you suggested
Simperfit commentedDec 11, 2017
Could you please rebase to fix the conflict ? |
| $options =array(); | ||
| $label =$input->getOption('label'); | ||
| if (null !==$label &&'' !==trim($label)) { | ||
| $options =array('graph' =>array('label' =>$input->getOption('label'))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You should be using $label instead of $input->getOption('label').
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thx, it's done
fabpot commentedDec 11, 2017
@shdev Can you rebase the pull request? You've merged master, but we don't merge pull requests with merge commits. I can help you do that if needed. Thanks. |
shdev commentedDec 11, 2017
@fabpot Thx. It would be nice, if you give me some hints to do the rebase. Sorry for the merges, I did the changes on Github.com and I'm not familiar with rebasing there |
- Workflow Command labels a graph with workflow name if option is set
- [] -> array()
- Improvement from@ro0NL
- Fabbot.io suggestion
5468fa5 toa7875edComparefabpot commentedDec 11, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I don't think it's possible to rebase from the UI. I see that you did everything with the web UI, so I've just done the rebase for you. I've downloaded your code and did a |
shdev commentedDec 11, 2017
Thank you@fabpot for the work, next time I use rebase |
a7875ed to9d0dda3Comparefabpot commentedDec 11, 2017
Thank you@shdev. |
This PR was squashed before being merged into the 4.1-dev branch (closes#25148).Discussion----------Pr/workflow name as graph label| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |This pull request added an option to the workflow dumper command, which allows you to add a graph label with the workflow name to the output. Without the option nothing changed the behavior from before.Example call:```bashbin/console workflow:dump <workflowname> --label=custom_label```Commits-------0afce8d Pr/workflow name as graph label
Uh oh!
There was an error while loading.Please reload this page.
This pull request added an option to the workflow dumper command, which allows you to add a graph label with the workflow name to the output. Without the option nothing changed the behavior from before.
Example call: