Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[SecurityBundle][Security][Translation] trigger some deprecations for legacy methods#25131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedNov 23, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We also need to deprecate thelogout_on_user_change firewall config node
| /** | ||
| * Disables dumper backup. | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@deprecated annotations are missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed
| publicfunctionsetLogoutOnUserChange($logoutOnUserChange) | ||
| { | ||
| // no-op, methodto bedeprecatedin 4.1 | ||
| @trigger_error(sprintf('The %s() methodisdeprecatedsince 4.1 and will be removed in 5.0.',__METHOD__)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
missingE_USER_DEPRECATED error level.
| */ | ||
| publicfunctionsetBackup($backup) | ||
| { | ||
| @trigger_error(sprintf('The %s() method is deprecated since 4.1 and will be removed in 5.0.',__METHOD__)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
missingE_USER_DEPRECATED error level.
| publicfunctiondisableBackup() | ||
| { | ||
| // to be deprecated in 4.1 | ||
| @trigger_error(sprintf('The %s() method is deprecated since 4.1 and will be removed in 5.0.',__METHOD__)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
missingE_USER_DEPRECATED error level.
600c817 to3909cc4Comparef823881 to7b209e1Comparexabbuh commentedNov 23, 2017
comments addressed, tests pass |
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
UPGRADE-4.1.md Outdated
| Security | ||
| -------- | ||
| * the`ContextListener::setLogoutOnUserChange()` method is deprecated and will be removed in 5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Missing cap and dot (same below) and in other files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed
| /** | ||
| * Disables dumper backup. | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed
chalasr commentedNov 26, 2017
Thank you@xabbuh. |
…eprecations for legacy methods (xabbuh)This PR was merged into the 4.0-dev branch.Discussion----------[SecurityBundle][Security][Translation] trigger some deprecations for legacy methods| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Commits-------e3396ea trigger some deprecations for legacy methods