Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][DX] Display a nice error message if an enabled component is missing#25094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[FrameworkBundle][DX] Display a nice error message if an enabled component is missing#25094
Uh oh!
There was an error while loading.Please reload this page.
Conversation
derrabus commentedNov 21, 2017
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25093 |
| License | MIT |
| Doc PR | N/A |
nicolas-grekas commentedNov 22, 2017
Could you please check if that happens for other components also? |
| if ($this->isConfigEnabled($container,$config['form'])) { | ||
| if (!class_exists('Symfony\Component\Form\Form')) { | ||
| thrownewLogicException('Form support cannot be enabled. Please install the Form component.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
just to match similar messages:Form support cannot be enabled as the Form component is not installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
✅
xabbuh commentedNov 22, 2017
For other components we did this in 3.3. Should we merge the PR into the |
derrabus commentedNov 22, 2017
@nicolas-grekas Serializer is also affected. I can enable the component without having it installed and FrameworkBundle would register the |
derrabus commentedNov 22, 2017
I've also checked the validator: When enabling it, |
4b86116 toe31badcComparederrabus commentedNov 22, 2017
Do you think, we can remove those lines? symfony/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php Lines 181 to 183 in4c93028
Installing Validator without Translation is not possible, enabling validation without the Validator component will be caught elsewhere. So this block just generates a confusing error message. |
e31badc to127b9deCompare
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
let's go for 3.3
127b9de to2b45805Comparederrabus commentedNov 22, 2017
3.3 it is, then. |
nicolas-grekas commentedNov 22, 2017
Thank you@derrabus. |
…nabled component is missing (derrabus)This PR was merged into the 3.3 branch.Discussion----------[FrameworkBundle][DX] Display a nice error message if an enabled component is missing| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#25093| License | MIT| Doc PR | N/ACommits-------2b45805 Display a nice error message if the form/serializer component is missing.
nicolas-grekas commentedNov 22, 2017
@derrabus about#25094 (comment), you reverted your idea? |
derrabus commentedNov 22, 2017
@nicolas-grekas For now, yes. That change conflicted with the 3.3 branch. I will setup a 3.3 app tonight and test again. |