Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Disable container inlining when legacy inlining has been used#25082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedNov 21, 2017
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25059 |
| License | MIT |
| Doc PR | - |
aeb76ec to8629838Compare| if ($this->loadClassCache ||class_exists(ClassCollectionLoader::class,false)) { | ||
| // if legacy inlining has been used, disable container inlining | ||
| $container->getParameter('container.dumper.inline_class_loader',false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
- getParameter+ setParameter
? But that's aFrozenParameterBag here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
good catch, should be better now
8629838 to4a11683Comparefabpot commentedNov 21, 2017
Thank you@nicolas-grekas. |
…ng has been used (nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[HttpKernel] Disable container inlining when legacy inlining has been used| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#25059| License | MIT| Doc PR | -Commits-------4a11683 [HttpKernel] Disable container inlining when legacy inlining has been used