Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Bridge/PhpUnit] Remove trailing "\n" from ClockMock::microtime(false)#25072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedNov 21, 2017
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25050 |
| License | MIT |
| Doc PR | - |
sroze commentedNov 21, 2017
That's a BC break. |
nicolas-grekas commentedNov 21, 2017
Thank you@joky. |
…otime(false) (joky)This PR was merged into the 2.8 branch.Discussion----------[Bridge/PhpUnit] Remove trailing "\n" from ClockMock::microtime(false)| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#25050| License | MIT| Doc PR | -Commits-------5ddb121 [Bridge/PhpUnit] Remove trailing "\n" from ClockMock::microtime(false)
nicolas-grekas commentedNov 21, 2017
@sroze it's not: the reference is the native microtime, any divergence from it is a bug. That's a mock, it's optional and doesn't run at runtime. |
guillaume-a commentedNov 21, 2017
@nicolas-grekas you're welcome. It's my first contrib. I'll try to do better next time (correct lower branche, correct commit comment, ...) |