Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Allow EnumNode name to be null#25048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
MatTheCat commentedNov 20, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25046 |
| License | MIT |
nicolas-grekas commentedNov 20, 2017
Thanks, could you add a test case please? |
MatTheCat commentedNov 20, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yep, guess74b9fb1 will be enough? |
| publicfunctiontestConstructionWithNullName() | ||
| { | ||
| newEnumNode(null,null,array('foo')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please call->finalize() or so to make the test not risky
| publicfunctiontestConstructionWithNullName() | ||
| { | ||
| $node =newEnumNode(null,null,array('foo')); | ||
| $node->finalize('foo'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please assert it (sorry I've been unclear) :)
MatTheCat commentedNov 20, 2017
Woops sorry 😓 |
nicolas-grekas commentedNov 20, 2017
Thank you@MatTheCat. |
This PR was squashed before being merged into the 4.0-dev branch (closes#25048).Discussion----------Allow EnumNode name to be null| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#25046| License | MITCommits-------57d0636 Allow EnumNode name to be null