Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Skip hot_path tag for deprecated services as their class might also be#25037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedNov 19, 2017
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #24959 |
| License | MIT |
| Doc PR | - |
| if ($valueinstanceof Reference && ContainerBuilder::IGNORE_ON_UNINITIALIZED_REFERENCE !==$value->getInvalidBehavior() &&$this->container->has($id = (string)$value)) { | ||
| $definition =$this->container->findDefinition($id); | ||
| if (!$definition->hasTag($this->tagName)) { | ||
| if (!$definition->hasTag($this->tagName) && !$value->isDeprecated()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
- !$value->isDeprecated()+ !$definition->isDeprecated()
?
But I'm still getting the deprecation with the mentioned reproducer and these changes :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should be good now
1c90d1b to6f134b5Compare6f134b5 to1775bbaComparefabpot commentedNov 20, 2017
Thank you@nicolas-grekas. |
…ass might also be (nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[DI] Skip hot_path tag for deprecated services as their class might also be| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24959| License | MIT| Doc PR | -Commits-------1775bba [DI] Skip hot_path tag for deprecated services as their class might also be