Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Dont create empty bundles directory by default#25033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| // Create the bundles directory otherwise symlink will fail. | ||
| $bundlesDir =$targetArg.'/bundles/'; | ||
| $this->filesystem->mkdir($bundlesDir,0777); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
given symlink() creates the parent directory, and mkdir() handles parents recursively, we could drop this line.
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ok for 3.4 to me
fabpot commentedNov 20, 2017
Thank you@ro0NL. |
…efault (ro0NL)This PR was merged into the 3.4 branch.Discussion----------[FrameworkBundle] Dont create empty bundles directory by default| Q | A| ------------- | ---| Branch? | 3.4 / 4.1?| Bug fix? | yes?| New feature? | no| BC breaks? | no?| Deprecations? | no| Tests pass? | yes| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!--highly recommended for new features-->we still run `assets:install` by default, which in bundle-less apps gives this annoying empty public/bundles dir and some useless cli output, all the time. This fixes it.Commits-------f8e7478 [FrameworkBundle] Dont create empty bundles directory
we still run
assets:installby default, which in bundle-less apps gives this annoying empty public/bundles dir and some useless cli output, all the time. This fixes it.