It took me all the flight back from Cluj to figure out this is the only way to solve this nasty issue created by phpunit generating inlinedrequire_once in the global scope for isolated tests.
This mechanism predates the autoloading mechanism, and it's behavior is just hardcoded.
Needs to be merged in 3.4, where the split container triggers this situation very quickly.

Will allow removing thefunction_exists('__phpunit_run_isolated_test') workarounds already in place in the code base (2.7 up to master.)

nicolas-grekas added this to the3.4 milestone

Nov 19, 2017

carsonbot added Status: Needs Review Bug labels

Nov 19, 2017

[Bridge\PhpUnit] Disable broken auto-require mechanism of phpunit

0577d20

nicolas-grekas changed the base branch from3.4 to3.3

November 19, 2017 17:07

nicolas-grekas force-pushed thephpunit-blacklist-all branch fromaf081f3 to0577d20Compare

November 19, 2017 17:07

Copy link

MemberAuthor

nicolas-grekas commentedNov 19, 2017

moved to 3.3 to prevent conflicts between local and vendor phpunit bridges

nicolas-grekas modified the milestones:3.4,3.3

Nov 19, 2017

nicolas-grekas merged commit0577d20 intosymfony:3.3

Nov 19, 2017

nicolas-grekas added a commit that referenced this pull request

Nov 19, 2017

bug#25032[Bridge\PhpUnit] Disable broken auto-require mechanism of …

146cefd

…phpunit (nicolas-grekas)This PR was merged into the 3.3 branch.Discussion----------[Bridge\PhpUnit] Disable broken auto-require mechanism of phpunit| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#25017| License       | MIT| Doc PR        | -It took me all the flight back from Cluj to figure out this is the only way to solve this nasty issue created by phpunit generating inlined `require_once` in the global scope for isolated tests.This mechanism predates the autoloading mechanism, and it's behavior is just hardcoded.Needs to be merged in 3.4, where the split container triggers this situation very quickly.Will allow removing the `function_exists('__phpunit_run_isolated_test')` workarounds already in place in the code base (2.7 up to master.)Commits-------0577d20 [Bridge\PhpUnit] Disable broken auto-require mechanism of phpunit

nicolas-grekas mentioned this pull request

Nov 19, 2017

Remove function_exists(__phpunit_run_isolated_test) checks#25034

Merged

nicolas-grekas added a commit that referenced this pull request

Nov 19, 2017

minor#25034Remove function_exists(__phpunit_run_isolated_test) chec…

4c5d9cf

…ks (nicolas-grekas)This PR was merged into the 2.7 branch.Discussion----------Remove function_exists(__phpunit_run_isolated_test) checks| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -As now permitted by#25032Commits-------a512217 Remove function_exists(__phpunit_run_isolated_test) checks

Copy link

Contributor

greg0ire commentedNov 19, 2017•
edited
Loading

I'm getting

phpunitPHPUnit 5.7.23 by Sebastian Bergmann and contributors.Cannot declare class PHPUnit_Util_Blacklist, because the name is already in usevendor/bin/simple-phpunitwhich: no composer.phar in (/usr/lib64/qt-3.3/bin:/usr/local/bin:/usr/bin:/bin:/usr/games:/home/greg/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/greg/src/shunit2:/home/greg/.fzf/bin)PHPUnit 5.7.25 by Sebastian Bergmann and contributors.Cannot declare class PHPUnit_Util_Blacklist, because the name is already in use

since upgrading to the latest 3.4.

Not entirely sure it's related yet.

UPDATE: I have the same issue with 3.x, I'll try bisecting.

Copy link

Contributor

greg0ire commentedNov 19, 2017•
edited
Loading

0577d20 is the first bad commit

commit 0577d20ade7d6191c68174c8a3fe68d84072e442Author: Nicolas Grekas <nicolas.grekas@gmail.com>Date:   Sun Nov 19 14:29:22 2017 +0200    [Bridge\PhpUnit] Disable broken auto-require mechanism of phpunit:040000 040000 4c11b70dd68fe5f6fa1cadd4058c8ab9eaca6d6d b329a21a1e6bc48a4abf48379745af28e6d443d9 Msrc

nicolas-grekas deleted the phpunit-blacklist-all branch

November 19, 2017 19:15

Copy link

MemberAuthor

nicolas-grekas commentedNov 19, 2017

did you remove the.phpunit cache folder?

Copy link

Contributor

greg0ire commentedNov 19, 2017•
edited
Loading

I just tried removing./vendor/symfony/phpunit-bridge/bin/.phpunit, it doesn't help, be it with the phar or with simple-phpunit

Copy link

Contributor

greg0ire commentedNov 19, 2017

Here is a simple reproducer:

git clone git@github.com:sonata-project/SonataMediaBundle.gitcd SonataMediaBundlecomposer require symfony/symfony '3.3.x-dev as 3.3.0'vendor/bin/simple-phpunit

Copy link

MemberAuthor

nicolas-grekas commentedNov 19, 2017

@greg0ire can you try again? could/should be fixed.

Copy link

Contributor

greg0ire commentedNov 19, 2017

No luck it seems, with both the phar and simple-phpunit (with.phpunit removed)

composer update -vLoading composer repositories with package informationUpdating dependencies (including require-dev)Dependency resolution completed in 0.711 secondsAnalyzed 13943 packages to resolve dependenciesAnalyzed 521378 rules to resolve dependenciesDependency resolution completed in 0.000 secondsPackage operations: 0 installs, 1 update, 0 removalsUpdates: symfony/symfony:3.3.x-dev 0187e9b  - Updating symfony/symfony 3.3.x-dev (f2fc7bf => 0187e9b):  Checking out 0187e9b3400e55b978901483ad71f40dc48c70ed    Pulling in changes:      0187e9b340 - Nicolas Grekas: [Bridge/PhpUnit] Fix compat with phpunit 4.8 & bridge <=3.3.13Package amazonwebservices/aws-sdk-for-php is abandoned, you should avoid using it. Use aws/aws-sdk-php instead.Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead.Writing lock fileGenerating autoload files╭─greg@liche in /tmp/SonataMediaBundle on 3.x ✘ (origin/3.x)╰$ phpunit                                            PHPUnit 5.7.23 by Sebastian Bergmann and contributors.Cannot declare class PHPUnit_Util_Blacklist, because the name is already in use

Copy link

MemberAuthor

nicolas-grekas commentedNov 19, 2017

ok, then I need a reproducer that actually works :)
the previous didn't have the issue actually
exact PHP + phpunit versions might help?

Copy link

Contributor

greg0ire commentedNov 19, 2017•
edited
Loading

Here you go:

php --versionPHP 7.1.11 (cli) (built: Oct 25 2017 07:27:25) ( NTS )Copyright (c) 1997-2017 The PHP GroupZend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies    with Xdebug v2.5.5, Copyright (c) 2002-2017, by Derick Rethansphpunit --versionPHPUnit 5.7.23 by Sebastian Bergmann and contributors.vendor/bin/simple-phpunit --versionwhich: no composer.phar in (/usr/lib64/qt-3.3/bin:/usr/local/bin:/usr/bin:/bin:/usr/games:/home/greg/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/greg/src/shunit2:/home/greg/.fzf/bin)PHPUnit 5.7.25 by Sebastian Bergmann and contributors.

Not sure why this can't be reproduced easily 😅

Copy link

MemberAuthor

nicolas-grekas commentedNov 20, 2017

@greg0ire OK, actually that's a bug in Sonata's tests/bootstrap.php:
the bridge isnot provided by thesymfony/symfony: even if the code is there, it is voluntarily excluded from "replace" and "autoload" sections in symfony's main composer.json. The lines in your bootstrap.php files that looks for the bridge in symfony/symfony need to be removed.