Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Hide server:log command based on deps#25027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@sroze
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#25025
LicenseMIT
Doc PRø

Remove theserver:log command if monolog is not installed.

@ro0NL
Copy link
Contributor

in fact, the issue looks related to lazy command loading givenServerLogCommand::isEnabled is called 🤔

looking atApplication::get we calladd($lazyLoadedCommand), butadd() itself doesnt register if it's a disabled command, yetget() happily returns $lazyLoadedCommand anyway. Causingserver:log also to look available inbin/console list.

chalasr reacted with thumbs up emoji

@chalasr
Copy link
Member

See#25030

@sroze
Copy link
ContributorAuthor

I think I prefer your approach@chalasr 👍

Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Actually this one stays fine regarding the framework, no need to process a useless definition esp. based on class existence.

@nicolas-grekas
Copy link
Member

Thank you@sroze.

@nicolas-grekasnicolas-grekas merged commitb505ac7 intosymfony:3.4Nov 19, 2017
nicolas-grekas added a commit that referenced this pull requestNov 19, 2017
…roze)This PR was merged into the 3.4 branch.Discussion----------[FrameworkBundle] Hide server:log command based on deps| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#25025| License       | MIT| Doc PR        | øRemove the `server:log` command if monolog is not installed.Commits-------b505ac7 Remove the `server:log` command if monolog is not loaded
@srozesroze deleted the issue-25025-hide-serverlog-based-on-deps branchNovember 19, 2017 20:19
This was referencedNov 21, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@sroze@ro0NL@chalasr@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp